Deprecated usage of ValidatorInterface

[soullivaneuh]

Concerned file: https://github.com/schmittjoh/serializer/blob/master/src/JMS/Serializer/EventDispatcher/Subscriber/SymfonyValidatorSubscriber.php#L30

Related notice:

 * @deprecated since version 2.5, to be removed in 3.0.
 *             Use {@link \Symfony\Component\Validator\ValidatorInterface} instead.

As this class is passed on the constructor, don't really know how to manage it.

Maybe create a legacy class? Where this class is used?

Regards

[schmittjoh]

Not sure this message makes sense, we are already using this interface?

[soullivaneuh]

Seems yes. See your SymfonyValidatorSubscriber class. 👍

[stof]

Well, given the API used in this subscriber, it is very easy to support both the old and the new validator interfaces: just accept both in the constructor. The API used in the code is common to both versions (the old API has more optional args in its validate() method, but the subscriber does not use them)

[soullivaneuh]

@stof Yes, but it use groups arguments that is not the second parameter on the new interface. Have to check that.

[stof]

Ah indeed. I missed the fact that the second argument was used. It is the third argument in the new API.
This can easily be checked with an instanceof check to switch between API.

[soullivaneuh]

@stof yes. I did it on #491.

[goetas]

solved in #682