Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getClassName regex may incorrectly retrieve a false class name from comments above the class. #460

Closed
rhousworth opened this issue Jun 10, 2015 · 1 comment

Comments

@rhousworth
Copy link

A comment such as "Any class that extends this one should..." above the class definition will result in an attempt to find a class named "that" in the given namespace, resulting in a rather cryptic error message. The solution would be to strip comments from the contents of the file before attempting to match the class name. See getClassName in AnnotationConfigurationPass.php.

@goetas
Copy link
Collaborator

goetas commented Apr 24, 2017

Closing, Sorry for the long feedback loop. If the problem is still here, feel free to comment (pointing out the code that presents the issue) it and I will re-open the issue.

@goetas goetas closed this as completed Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants