Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move FormErrorHandler to the bundle #664

Closed
hpatoio opened this issue Oct 28, 2016 · 1 comment
Closed

Move FormErrorHandler to the bundle #664

hpatoio opened this issue Oct 28, 2016 · 1 comment

Comments

@hpatoio
Copy link

hpatoio commented Oct 28, 2016

I think that FormErrorHandler should be moved from jms/serializer to jms/serializer-bundle because it handle Symfony forms and not a generic type.

I can submit PRs to both repo but I first would like to know if I'm right or I'm missing something.

@goetas
Copy link
Collaborator

goetas commented Oct 28, 2016

the tricky part it that somebody can be using the symfony form component without the symfony framework itself. for that reason this class has to stay here (or in a separate package... but this only for 2.0)

@goetas goetas closed this as completed Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants