Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "bool" Annotation/Type #807

Closed
VincentChataignier opened this issue Aug 10, 2017 · 4 comments · Fixed by #818
Closed

Add "bool" Annotation/Type #807

VincentChataignier opened this issue Aug 10, 2017 · 4 comments · Fixed by #818
Labels
Feature Request

Comments

@VincentChataignier
Copy link

VincentChataignier commented Aug 10, 2017 •
edited
Loading

Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? no

Can we add the type "bool" to Annotation/Type with "boolean" type ?
Like "integer" and "int" type.

Example :

/**
* @Assert\Type(type="bool")
*/

Thank you for your feedback 😃
@goetas
Copy link
Collaborator

goetas commented Aug 10, 2017

why not :) PR are welcome!

@VincentChataignier
Copy link
Author

Ok 😃 I will try to analyse the code and adding with PR.

@goetas
Copy link
Collaborator

goetas commented Aug 10, 2017 •
edited
Loading

tests and documentation in this case are "must" to have :)

@Majkl578 Majkl578 mentioned this issue Sep 13, 2017
Merged
@Majkl578
Copy link
Contributor

#818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added bool type alias Majkl578/jms-serializer
3 participants
@Majkl578 @goetas @VincentChataignier