GSFont: save() issues

[Mark2Mark]

• When executing font.save() on a font that is loaded with GSFont({PATH}) (not in the UI), it fails with the error:

  File "GlyphsApp/GlyphsApp/__init__.py", line 4174, in Font__save__
ValueError: No path set

While when executing font.save() on a font that is open in the UI, it works as expected.

---

The Documentation says:

If no path is given, it saves to the existing location.

Parameters:
path (str) – Optional file path

formatVersion (int) – the format of the file

makeCopy (bool) – saves a new file without changeing the documents file paths

• When setting makeCopy=True, it then also expects a filePath. The "optional" filePath claim seems misleading then.
• When setting makeCopy to True AND providing a filePath, there is no error, but there’s also no copy created. (Font.save(path="/Users/.../Desktop/New Font.glyphs", makeCopy=True))
• Specifying the formatVersion (e.g. formatVersion=2 from a file that is version 3) does nothing, it should probably raise an error as it is likely to be not compatible. However, the other way around also does nothing: Font.save(formatVersion=3) where the opened file is set to version 2.
• Wording proposal for above-mentioned docu: "path (str) – Optional file path including filename and suffix."

[schriftgestalt]

When a font is loaded directly (GSFont({PATH})) it doesn't have a document and thous can’t store a file path. So .save() always needs a path argument.

when makeCopy is set, it always requires a file paths as that is the purpose of that flag.