Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alembic migrations should have associated test cases #555

Open
brassy-endomorph opened this issue Sep 9, 2024 · 0 comments
Open

Alembic migrations should have associated test cases #555

brassy-endomorph opened this issue Sep 9, 2024 · 0 comments
Assignees

Comments

@brassy-endomorph
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Migrations can be very error prone, and unusual or unexpected state on a prod server can cause migrations to fail. We can try to anticipate these and write tests cases to ensure migrations are always successful.

Describe the solution you'd like

SecureDrop has a strategy in test_alembic.py and the related tests/migrations directory.

Describe alternatives you've considered

I do not know of any other ways people test Alembic migrations. More research might lead us to a better solution.

Additional context

I have seen so many "lgtm" migrations fail in prod :(( the problem is real.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant