Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Lens reader out to its own repository #136

Open
CAYdenberg opened this issue Jul 7, 2017 · 3 comments
Open

Split Lens reader out to its own repository #136

CAYdenberg opened this issue Jul 7, 2017 · 3 comments

Comments

@CAYdenberg
Copy link
Contributor

Subtask of #118. Ideally use Lens-starter to add custom panels and converters. The built project could then be included in ScienceFair as an npm module.

@blahah
Copy link
Member

blahah commented Jul 8, 2017

@CAYdenberg this work was originally done in https://github.com/blahah/lens-starter

I've imported that fork to a new repo here, where we can expand the tooling to build and publish the compiled lens reader.

I will merge all the changes I made to the compiled Lens back into the builder.

@CAYdenberg
Copy link
Contributor Author

OK, I see. So running gulp in that project should build a dist directory that has everything you need in it? Or did you do it some other way (I notice there's check-in lens folder in that project but the gulp destinations are still dist)

@blahah
Copy link
Member

blahah commented Jul 10, 2017

@CAYdenberg yeah that lens dir is still hanging around from the olden days. I'll clean up the repo so it has a reasonable structure and workflow, then we can start planning where it goes next.

I think at least for now it needs:

  1. to build a distributable lens bundle
  2. to be able to release just that distributable bundle as sciencefair-lens or something that we can depend on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants