Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codimd to Meshapps umbrella chart #12

Merged
merged 3 commits into from
Nov 26, 2020

Conversation

SamuAlfageme
Copy link
Member

@SamuAlfageme SamuAlfageme commented Sep 28, 2020

This also fixes an issue with the default collabora image value as well as some wrong terms in the README.

Closes sciencemesh/sciencemesh#74

SamuAlfageme added a commit to sciencemesh/sciencemesh that referenced this pull request Oct 2, 2020
Also, apply a temporary patch on the collabora-code.image scoping
issue reported on sciencemesh/charts#12
until that PR gets merged
- As described within the docs on:
  sciencemesh/sciencemesh#156

- Update meshapps README to point to the /integrations url on the
  sciencemesh docs
@SamuAlfageme SamuAlfageme marked this pull request as ready for review November 4, 2020 10:08
@Daniel-WWU-IT
Copy link
Member

There are a few more environment variables we've set in our test deployment; not sure if they're really needed:

@SamuAlfageme
Copy link
Member Author

SamuAlfageme commented Nov 4, 2020

@Daniel-WWU-IT thanks a lot for your review ❤️

The CMD_APPLIANCE_MODE set to true is already present on the values that are part of this PR:

CMD_APPLIANCE_MODE: true

And indeed, the URL_PATH and SAVE_WEBHOOK are considered site-specific values and mentioned on the companion doc PR

@glpatcern
Copy link
Member

And indeed, the URL_PATH and SAVE_WEBHOOK are considered site-specific values and mentioned on the companion doc PR

[Reviewing some backlog] I agree with you Samuel, nevertheless any chance to "parameterize" such variables? In particular the CMD_SAVE_WEBHOOK must always look like https://<ingress>/<wopibridge_path>/save.

@SamuAlfageme
Copy link
Member Author

@glpatcern I agree, making the config as lean as possible (as in no. of variables to be passed to deploy the chart) and avoiding duplicated variables/content is always a design goal I try to apply. For instance, that is how we generate the WOPI Server/Bridge External URLs currently.

The issue to generate the CMD_SAVE_WEBHOOK content lies in how the two charts are decoupled: there is no way to access the IOP-specific variables (e.g. the WOPI Bridge ingress hostname and path) from a different chart (MESHApps, in this case).

This could be done if we ever consider creating a meta-umbrella chart that agglutinates these two by using Helm's global chart values.

@SamuAlfageme SamuAlfageme merged commit 2558ce7 into sciencemesh:master Nov 26, 2020
@SamuAlfageme SamuAlfageme deleted the meshapps_codimd branch November 26, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CodiMD K8s chart to the IOP
3 participants