-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codimd to Meshapps umbrella chart #12
Add codimd to Meshapps umbrella chart #12
Conversation
Also, apply a temporary patch on the collabora-code.image scoping issue reported on sciencemesh/charts#12 until that PR gets merged
- As described within the docs on: sciencemesh/sciencemesh#156 - Update meshapps README to point to the /integrations url on the sciencemesh docs
There are a few more environment variables we've set in our test deployment; not sure if they're really needed:
|
@Daniel-WWU-IT thanks a lot for your review ❤️ The Line 23 in 1bf6f93
And indeed, the |
[Reviewing some backlog] I agree with you Samuel, nevertheless any chance to "parameterize" such variables? In particular the |
@glpatcern I agree, making the config as lean as possible (as in no. of variables to be passed to deploy the chart) and avoiding duplicated variables/content is always a design goal I try to apply. For instance, that is how we generate the WOPI Server/Bridge External URLs currently. The issue to generate the This could be done if we ever consider creating a meta-umbrella chart that agglutinates these two by using Helm's |
This also fixes an issue with the default
collabora
image value as well as some wrong terms in the README.Closes sciencemesh/sciencemesh#74