-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Ruff's docstring-code-format #343
Comments
It doesn’t support .md or .rst files quite yet. It should soon. |
Ah, good call out, thanks! |
|
When using ruff for docstring formatting, should repo-review mark not using blacken-doc in red? And this link doesn't seem to exist: https://learn.scientific-python.org/development/guides/style/#PC111 |
This check is for formatting code samples in docs (not docstrings), which I think ruff doesn’t support yet (basically all the pieces are there, but not the infrastructure. If the link is missing, that’s a bug, will check! |
If we add
to |
I think we should be recommending it, but we should also make sure we don't have overlap with blacken-docs trying to format code blocks in python files. I'd not thought of it doing that, but if it does, we should note how to avoid it. |
Ruff has a replacement for blacken-docs: astral.sh/blog/ruff-v0.1.8#formatting-code-snippets-in-docstrings.
In Jupyter Server we're skipping
PC111
for now.The text was updated successfully, but these errors were encountered: