Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate prettier pre-commit hook #439

Closed
ariostas opened this issue Jun 10, 2024 · 5 comments
Closed

Deprecate prettier pre-commit hook #439

ariostas opened this issue Jun 10, 2024 · 5 comments

Comments

@ariostas
Copy link

The prettier pre-commit hook has been deprecated and the repo has been archived since prettier made some breaking changes.

@ariostas
Copy link
Author

They have some alternatives here, but none of them seem particularly convenient.

@kratsg
Copy link
Contributor

kratsg commented Jun 12, 2024

I'm using

  - repo: https://github.com/rbubley/mirrors-prettier
    rev: "v3.3.2"
    hooks:
      - id: prettier
        types_or: [yaml, markdown, html, css, scss, javascript] #, json]
        args: [--prose-wrap=always]

this seems to be maintained for now...

@burgholzer
Copy link
Contributor

The convenient thing about the above mirror is that it also only tags non-pre-release versions so that the weekly struggle of reverting the pre-commit autoupdate from the 4.x pre-release version to the latest 3.x stable release is eliminated.

Would it be okay for sp-repo-review to recommend the alternative mirror?
Or could the check for the presence of prettier in the pre-commit config be loosened up so that it passes as long as the URL matches https://github.com/*/mirrors-prettier?

@henryiii
Copy link
Collaborator

henryiii commented Aug 5, 2024

We can list popular mirrors, and eventually start recommending one. #460 makes this easier.

@henryiii
Copy link
Collaborator

Done in both #461 and fully moved in #476.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@kratsg @henryiii @burgholzer @ariostas and others