Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request access for shapely #63

Closed
jorisvandenbossche opened this issue Feb 12, 2024 · 9 comments
Closed

Request access for shapely #63

jorisvandenbossche opened this issue Feb 12, 2024 · 9 comments
Assignees

Comments

@jorisvandenbossche
Copy link
Member

While not a core project, Shapely is widely used in geospatial subcommunity. Shapely is a compiled package, and apart from an external dependency on GEOS, it also has a build dependency on numpy, so especially with the upcoming numpy 2.0 it would be nice to host shapely nightly wheels built with numpy 2.0.

(I see there is some discussions in other issues about criteria when to include a package, tried to reflect that in the above paragraph)

cc @martinfleis

@matthewfeickert
Copy link
Member

Thanks for the Issue @jorisvandenbossche! Also thanks for being extra diligent and noticing some of the other ongoing discussion.

Once we get thngs figured out in Issue #30 (see related discussion in Issue #29) we'll be able to give you information on how to proceed here. If you're interested, I would suggest subscribing to those Issues.

@matthewfeickert
Copy link
Member

matthewfeickert commented Feb 22, 2024

@jorisvandenbossche Good news, we have the approval (#30 (comment)) to add shapely to the nightly wheels Anaconda Cloud org https://anaconda.org/scientific-python-nightly-wheels/ !

To get started on this please do the following:

Steps to gain upload access to https://anaconda.org/scientific-python-nightly-wheels/

image

If you'd also like to use the scientific/upload-nightly-action GitHub Action that this repository provides please check out this repo's README. If you need to collect wheels from different CI jobs, consider creating a new GitHub Actions workflow with logic similar to matplotlib's or Awkward's.

If you have any questions please just ask here!

@jorisvandenbossche
Copy link
Member Author

My Anaconda account: https://anaconda.org/jorisvandenbossche/

@jorisvandenbossche
Copy link
Member Author

  • Direct me (@matthewfeickert) to a shapely nightly wheel for me to upload to create the package in the registry

The wheels are built on github actions, and so for the currently last commit on main, you can find it here: https://github.com/shapely/shapely/actions/runs/7931478835 (scroll down to the artifacts, and then download the wheels for any of the architectures should work I guess)

@jarrodmillman
Copy link
Member

Would it make sense to add geopandas as well?

@matthewfeickert
Copy link
Member

@jorisvandenbossche I've made https://anaconda.org/scientific-python-nightly-wheels/shapely/ and you should now have admin control over the shapely group. If you've created the API token then you should now be able to have your CI/CD workflow upload. 👍

@martinfleis
Copy link
Member

@jarrodmillman Geopandas is pure Python. Do we want to include packages like that as well? It won't take almost any space, that's for sure.

@stefanv
Copy link
Member

stefanv commented Feb 23, 2024

If it's pure Python, then CI can install directly from GitHub. I think it makes most sense to have binary artifacts in this repo.

@jorisvandenbossche
Copy link
Member Author

Thanks a lot @matthewfeickert !
Verified that I was added to the anaconda cloud account, and set up the upload action on the shapely side (shapely/shapely#1997, shapely/shapely#1998), the first set of wheels have been uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants