Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ refactoring: Make highlevel __repr__ safe for typetracers. #1218

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

jpivarski
Copy link
Member

@jpivarski jpivarski commented Jan 12, 2022

@douglasdavis, here's what it looks like with only the type section (no values section).

>>> import awkward._v2 as ak

>>> x = ak.Array([[1, 2, 3], [], [4]])
>>> ak.Array(x.layout.typetracer)
<Array-typetracer type='?? * var * int64'>

>>> x = ak.Record({"x": [1, 2, 3], "y": 1.1})
>>> ak.Record(ak.record.Record(x.layout.array.typetracer, 0))
<Record-typetracer type='{x: var * int64, y: float64}'>

@jpivarski jpivarski linked an issue Jan 12, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #1218 (c0bff9d) into main (0a0e9be) will decrease coverage by 0.07%.
The diff coverage is 67.12%.

Impacted Files Coverage Δ
src/awkward/_v2/_typetracer.py 68.94% <33.33%> (-0.25%) ⬇️
src/awkward/_v2/highlevel.py 64.43% <33.33%> (-0.56%) ⬇️
src/awkward/_v2/_slicing.py 83.79% <75.47%> (-2.48%) ⬇️
src/awkward/_v2/contents/regulararray.py 82.66% <80.00%> (+0.07%) ⬆️

@jpivarski jpivarski merged commit b640f63 into main Jan 13, 2022
@jpivarski jpivarski deleted the jpivarski/typetracer-highlevel-repr branch January 13, 2022 15:19
@jpivarski jpivarski changed the title Make highlevel __repr__ safe for typetracers. C++ refactoring: Make highlevel __repr__ safe for typetracers. Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typetracer array repr fails due to unknown length
1 participant