-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Windows 32-bit from the Python 3.10 build. #1237
Conversation
Codecov Report
|
Testing the deployment here, by the way: https://github.com/scikit-hep/awkward-1.0/actions/runs/1719986605 |
You could skip it instead (or also) in pyproject.toml; the benefit of the skip is that it works locally too. Technically, we don't really support local Windows runs yet... But the next cibuildwheel release should. Quite minor, this is fine. |
Now the MacOS build gets this far before failing:
I suppose we don't really need any includes, now that we're not supporting downstream dependencies of the C++ part. They'd be needed in the SDist, but not in wheels. I'm going to try this: --- a/setup.py
+++ b/setup.py
@@ -193,11 +193,6 @@ class Install(setuptools.command.install.install):
print("--- build directory -------------------------------------------")
tree("build")
- print("--- copying includes ------------------------------------------")
- shutil.copytree(
- os.path.join("include"), os.path.join(outerdir, "awkward", "include")
- )
-
print("--- outerdir after copy ---------------------------------------")
tree(outerdir) By the same logic, we also don't need to bundle any static libraries, just the dynamic ones. I'll start with this, though. |
Here's the next one: https://github.com/scikit-hep/awkward-1.0/actions/runs/1720551239 |
I think the problem is setuptools doesn't understand that PyPy and CPython are different. If you split the CPython and PyPy jobs, I think it will be fine. Not sure why PyPy 3.7 doesn't show that problem, and 3.8 does, though - but it might be "better" (more CPython-like) handling of build paths for PyPy 3.8. |
I keep doing other things and then coming back to check up on this. You have something specific in mind—could you set it up the way you're thinking? |
I've reverted the include file removal to verify my suspicion was correct, but if it's not useful, the static files should be removed, as they make the wheels larger (libs much more than include). |
Great, thank you very much! I see that it has been tested here: https://github.com/scikit-hep/awkward-1.0/actions/runs/1721784145 (the commit hex matches), so we know that it will work in a real release. I'll get started on that release right now. |
The static libraries are not useful, but the next release will be a prerelease. The frequency of non-prereleases has gone down considerably in the past year, so that alleviates some of the disk space pressure. Nevertheless, before 1.8.0, I'll try removing the static libraries. |
No description provided.