Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix ByteMaskedArray.simplify_optiontype() #1259

Merged
merged 4 commits into from
Jan 28, 2022

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Jan 28, 2022

Currently ByteMaskedArray.simplify_optiontype() has a few typos that mean it raises an AttributeError instead of returning a simplified layout.

@agoose77 agoose77 changed the title Fix: fix ByteMaskedArray.simplify_optiontype() Fix: fix ByteMaskedArray.simplify_optiontype() Jan 28, 2022
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #1259 (56312ea) into main (ab65e20) will increase coverage by 0.24%.
The diff coverage is 60.78%.

Impacted Files Coverage Δ
src/awkward/_v2/__init__.py 100.00% <ø> (ø)
src/awkward/_v2/_connect/numpy.py 58.63% <0.00%> (+0.17%) ⬆️
src/awkward/_v2/behaviors/string.py 71.42% <ø> (+16.88%) ⬆️
src/awkward/_v2/contents/__init__.py 100.00% <ø> (ø)
src/awkward/_v2/contents/emptyarray.py 69.36% <0.00%> (-0.18%) ⬇️
src/awkward/_v2/contents/indexedarray.py 60.64% <0.00%> (-0.10%) ⬇️
src/awkward/_v2/contents/indexedoptionarray.py 85.40% <0.00%> (+0.15%) ⬆️
src/awkward/_v2/contents/listarray.py 87.95% <0.00%> (+0.21%) ⬆️
src/awkward/_v2/contents/listoffsetarray.py 79.68% <0.00%> (+0.12%) ⬆️
src/awkward/_v2/contents/regulararray.py 82.85% <0.00%> (+0.18%) ⬆️
... and 146 more

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this; these are unquestionably bugs.

@jpivarski jpivarski merged commit 4d88dff into main Jan 28, 2022
@jpivarski jpivarski deleted the fix-bytemaskedarray-simplify_optiontype branch January 28, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants