Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ak.nan_to_num arguments to be arrays. #1298

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

jpivarski
Copy link
Member

This will unblock scikit-hep/vector#172, as soon is it gets into a release.

Rather than change Vector to get non-release candidate versions, I should try to get a release candidate for Awkward out. It's overdue.

@jpivarski jpivarski enabled auto-merge (squash) February 18, 2022 23:08
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #1298 (1a064bb) into main (8e68200) will increase coverage by 1.68%.
The diff coverage is 77.62%.

Impacted Files Coverage Δ
src/awkward/_v2/_connect/numba/arrayview.py 96.24% <ø> (ø)
src/awkward/_v2/_connect/numba/layout.py 87.01% <ø> (ø)
src/awkward/_v2/_prettyprint.py 63.79% <0.00%> (ø)
src/awkward/_v2/operations/convert/ak_from_cupy.py 25.00% <0.00%> (-50.00%) ⬇️
src/awkward/_v2/operations/convert/ak_to_arrow.py 60.00% <ø> (ø)
src/awkward/_v2/operations/describe/ak_type.py 44.11% <0.00%> (ø)
src/awkward/_v2/operations/structure/ak_isclose.py 100.00% <ø> (ø)
.../awkward/_v2/operations/structure/ak_nan_to_num.py 75.00% <ø> (ø)
src/awkward/_v2/operations/convert/ak_to_cupy.py 8.19% <3.44%> (-66.81%) ⬇️
src/awkward/_v2/operations/describe/ak_backend.py 9.52% <9.52%> (ø)
... and 86 more

@jpivarski jpivarski merged commit 8f4b7d7 into main Feb 18, 2022
@jpivarski jpivarski deleted the jpivarski/allow-nan_to_num-arguments-to-be-arrays branch February 18, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant