Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the Forms produced by the AwkwardForth generation agree with the awkward_form methods. #754

Closed
jpivarski opened this issue Oct 11, 2022 · 0 comments · Fixed by #790
Closed

Ensure that the Forms produced by the AwkwardForth generation agree with the awkward_form methods. #754

jpivarski opened this issue Oct 11, 2022 · 0 comments · Fixed by #790
Assignees
@jpivarski

Comments

@jpivarski
Copy link
Member

If they don't, make them the same.

The "uproot" parameters should be removed.

Some of the "__record__" parameters have the C++ name; this is a good idea. We should make sure that all of them do.
@jpivarski jpivarski added the next-release Required for the next release label Oct 31, 2022
@jpivarski jpivarski self-assigned this Nov 10, 2022
@jpivarski jpivarski mentioned this issue Nov 30, 2022
Merged
@jpivarski jpivarski linked a pull request Nov 30, 2022 that will close this issue
fix: all AwkwardForth Forms now agree with awkward_form method output. #790
Merged
@jpivarski jpivarski removed the next-release Required for the next release label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpivarski jpivarski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: all AwkwardForth Forms now agree with awkward_form method output. scikit-hep/uproot5
1 participant
@jpivarski