Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It appears that one of the Microsoft SCIM Validator tests is failing, and I suspect it might be a bug in their tool. I’m reporting this for awareness and further investigation #59

Open
omar7c3 opened this issue Oct 31, 2024 · 0 comments

Comments

@omar7c3
Copy link

omar7c3 commented Oct 31, 2024

I’ve noticed a bug on Microsoft’s end—one of their testing is failing per their tool (you can find it at this [link] https://scimvalidator.microsoft.com/) as shown below,

image

However, I don’t believe it’s a bug in the Scimmy library. The issue arises from a PATCH request with a blank required ‘Operations’ attribute. To address this, I made a tweak in the Messages.js file (specifically, I updated line 275 from if (this.#dispatched && !operations.length) to if (this.#dispatched && !operations)). This adjustment is relevant for those who want to use and test against the Microsoft SCIM Validator. And hey, kudos to you for implementing and publishing this fantastic SCIM library! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant