Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use picojson.h from /usr/include/picojson.h #81

Open
olifre opened this issue Feb 26, 2022 · 2 comments
Open

Unable to use picojson.h from /usr/include/picojson.h #81

olifre opened this issue Feb 26, 2022 · 2 comments

Comments

@olifre
Copy link
Contributor

olifre commented Feb 26, 2022

The code currently hardcodes use of <includepath>/picojson/picojson.h, while picojson natively installs into <prefix>/include/picojson.h, so a native installation can not be used, see:
https://github.com/kazuho/picojson/blob/111c9be5188f7350c2eac9ddaedd8cca3d7bf394/Makefile#L21

This issue is probably inherited from Thalhammer/jwt-cpp#213 .

@djw8605
Copy link
Contributor

djw8605 commented Feb 28, 2022

Should we wait for jwt-cpp to fix it?

@olifre
Copy link
Contributor Author

olifre commented Feb 28, 2022

That's probably the best course of action (even though it will not be fast). For now, I am using a rather ugly hack for packaging in Gentoo:
https://github.com/gentoo/guru/blob/3b569c6eb473d954f759bc638d8bc4e38bd06a18/dev-cpp/scitokens-cpp/scitokens-cpp-0.7.0.ebuild#L40-L41
However, of course I use a similar hack for jwt-cpp:
https://github.com/gentoo/guru/blob/3b569c6eb473d954f759bc638d8bc4e38bd06a18/dev-cpp/jwt-cpp/jwt-cpp-0.4.0.ebuild#L35

In scitokens-cpp, a direct include of picojson/picojson.h is done in src/scitokens_cache.cpp and src/scitokens_internal.cpp. Depending on how jwt-cpp will solve this, scitokens-cpp might inherit their CMake macro / config to determine the include path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants