Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure destructiveChanges.xml does not contains package.xml element #113

Merged

Conversation

scolladon
Copy link
Owner

What does this pull request contains? Explain your changes.


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Implement a post processing filtering to exclude element in
destructiveChanges.xml also present in package.xml

Does this close any currently open issues?


closes #111

  • Jest test to check the fix is applied are added.

Where has this been tested?


Operating System: Darwin Kernel Version 18.7.0: Tue Jan 12 22:04:47 PST 2021; root:xnu-4903.278.56~1/RELEASE_X86_64

yarn version: 1.22.10

node version: v15.12.0

git version: 2.31.0

sfdx version: sfdx-cli/7.93.1 darwin-x64 node-v15.12.0

sgd plugin version: sfdx-git-delta 4.2.3

Implement a post processing filtering to exclude element in
destructiveChanges.xml also present in package.xml
@scolladon scolladon merged commit 9729e2f into master Apr 2, 2021
@scolladon scolladon deleted the feature/exclude-same-member-from-package-and-destructive branch April 2, 2021 12:34
@MaciekLeks
Copy link

MaciekLeks commented Apr 3, 2021

when it will be realesed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doubled metadata destructive changes
3 participants