Fix Custom Label Addition package.xml generation #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove not used anymore _fillPackageFromFile Change the API _handleInFile => _handleInDiff (more accurate)
mehdicherf
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request contains? Explain your changes.
Explain your changes
Deal with added files the same as modified ones.
Previously the code red the information from the file in the file system for added file.
Which is inaccurate when the
--toparameter is different of the HEAD.This PR define the content of package.xml (and delta generation content) from the diff (not from the content of the current file)
Does this close any currently open issues?
closes #47
Where has this been tested?
Operating System: Darwin Kernel Version 18.7.0: Tue Jan 12 22:04:47 PST 2021; root:xnu-4903.278.56~1/RELEASE_X86_64
yarn version: 1.22.10
node version: v15.12.0
git version: 2.31.0
sfdx version: sfdx-cli/7.93.1 darwin-x64 node-v15.12.0
sgd plugin version: sfdx-git-delta 4.2.3