Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: silent SfdxCommand compilation issue #121

Merged
merged 3 commits into from
Apr 5, 2021
Merged

Conversation

scolladon
Copy link
Owner

What does this pull request contains? Explain your changes.


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Reapply tsconfig.json extends to salesforce ts devconfig compilation settings

Does this close any currently open issues?


closes #120

Where has this been tested?


Operating System: Darwin Kernel Version 18.7.0: Tue Jan 12 22:04:47 PST 2021; root:xnu-4903.278.56~1/RELEASE_X86_64

yarn version: 1.22.10

node version: v14.16.0

git version: git version 2.31.1

sfdx version: node-v14.16.0

sgd plugin version: 4.3.0

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #121 (0f356e6) into master (8121d3e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          18       18           
  Lines         395      395           
=======================================
  Hits          392      392           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8121d3e...0f356e6. Read the comment docs.

@scolladon scolladon merged commit d3af15a into master Apr 5, 2021
@scolladon scolladon deleted the fix/broken-sfdxcommand branch April 5, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Class constructor SfdxCommand cannot be invoked without 'new'
1 participant