fix: issue with path separator conversion in xml file and path portability #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve portability of the code
main would require a refactoring so it can be unit tested more easily
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
+ Coverage 99.25% 99.27% +0.01%
==========================================
Files 18 18
Lines 403 414 +11
==========================================
+ Hits 400 411 +11
Misses 3 3
Continue to review full report at Codecov.
|
1 task
mehdicherf
force-pushed
the
fix/path-portability
branch
from
d766a46
to
66697a1
Compare
|
Code Climate has analyzed commit 66697a1 and detected 0 issues on this pull request. View more on Code Climate. |
mehdicherf
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request contains
Explain your changes
Remove the path treatment for git diff file reader
Add path sanity treatment of config object
Does this close any currently open issues?
closes #152
Any particular element to being able to test locally
Smoke test + Unit test
Any other comments?
Where has this been tested?
It has been tested on both mac and windows
Operating System: Darwin Kernel Version 18.7.0: Mon May 3 20:41:19 PDT 2021; root:xnu-4903.278.68~1/RELEASE_X86_64 and Windows 10
yarn version: 1.22.10
node version: v14.16.0
git version: 2.32.0
sfdx version: sfdx-cli/7.105.0 darwin-x64 node-v14.16.0
sgd plugin version: 4.6.0