fix: -d usage with -t different than HEAD #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 418 433 +15
=========================================
+ Hits 418 433 +15
Continue to review full report at Codecov.
|
|
@mehdisfdc we need to discuss about that, it is tricky and the actual solution is suboptimal to me |
scolladon
force-pushed
the
fix/filecopy-to-not-latest-commit
branch
from
ea4a23f
to
f3b32b5
Compare
do not allow -d to be used with -t different of Head
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
scolladon
force-pushed
the
fix/filecopy-to-not-latest-commit
branch
from
8493812
to
4af132a
Compare
mehdicherf
reviewed
Jul 7, 2021
mehdicherf
reviewed
Jul 7, 2021
Co-authored-by: Mehdi Cherfaoui <[email protected]>
scolladon
force-pushed
the
fix/filecopy-to-not-latest-commit
branch
from
3c11e28
to
a2cd874
Compare
scolladon
changed the title
mehdicherf
previously approved these changes
Jul 9, 2021
mehdicherf
reviewed
Jul 9, 2021
Co-authored-by: Mehdi Cherfaoui <[email protected]>
|
Code Climate has analyzed commit 8416f0c and detected 0 issues on this pull request. View more on Code Climate. |
mehdicherf
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request contains
Explain your changes
Move the current repository when config.to is different than HEAD
In order to have the file and the version of the file related to the commit wanted
Does this close any currently open issues?
Nop
Any particular element to being able to test locally
Use jest and node
Any other comments?
Need to be roughly tested and also we need to look for other way to do it better
Where has this been tested?
Operating System: Darwin Kernel Version 19.6.0: Thu May 6 00:48:39 PDT 2021; root:xnu-6153.141.33~1/RELEASE_X86_64
yarn version: 1.22.10
node version: v14.16.0
git version: 2.32.0
sfdx version: sfdx-cli/7.107.0 darwin-x64 node-v14.16.0
sgd plugin version: 4.61