fix: implement new metadata handling for Bot #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Be careful, it should be merged after #220 !! |
scolladon
force-pushed
the
fix/bot-metadata
branch
from
21f76d8
to
5661d4e
Compare
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 494 494
=========================================
Hits 494 494
Continue to review full report at Codecov.
|
mehdicherf
previously approved these changes
Dec 15, 2021
scolladon
force-pushed
the
fix/bot-metadata
branch
from
b2cb29c
to
91724f7
Compare
|
Code Climate has analyzed commit c2e7206 and detected 0 issues on this pull request. View more on Code Climate. |
mehdicherf
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request contains
Explain your changes
Change the metadata definition for Bot and BotVersion
Create a dedicated handler for this new metadata kind
Create test class for it
Decomissionate old test class and metadata configuration
Does this close any currently open issues?
closes #219
Any particular element to being able to test locally
Follow the description of the related issue in order to create the right dataset.
use reproduction playground branch issue/219 with the following command:
Any other comments?
Where has this been tested?
Operating System: Darwin Kernel Version 19.6.0: Tue Oct 12 18:34:05 PDT 2021; root:xnu-6153.141.43~1/RELEASE_X86_64
yarn version: 1.22.17
node version: v14.18.1
git version: 2.34.1
sfdx version: sfdx-cli/7.130.1 darwin-x64 node-v14.18.1
sgd plugin version: 4.11.0