Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve markdown files spelling #266

Merged
merged 1 commit into from
Mar 27, 2022

Conversation

denisab85
Copy link
Contributor

What does this pull request contains


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Markdown files spelling correction.

Does this close any currently open issues?


closes #

  • Jest test to check the fix is applied are added.

Any particular element to being able to test locally


Any other comments?


Where has this been tested?


Operating System:

yarn version:

node version:

git version:

sfdx version:

sgd plugin version:

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #266 (8399750) into main (fddd7e4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #266   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          613       613           
=========================================
  Hits           613       613           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fddd7e4...8399750. Read the comment docs.

Copy link
Owner

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.md should not be touched

We are using husky 7 and we need those file in the husky folder, they should be rolledback

CHANGELOG.md Outdated
@@ -11,7 +11,7 @@ All notable changes to this project will be documented in this file. See [standa

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remark: this file should not be changed because it is auto generated.

If one day we need to rebuild it it will be erased

scolladon
scolladon previously approved these changes Mar 27, 2022
Copy link
Owner

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scolladon scolladon changed the title fix: markdown files spelling correction fix: improve markdown files spelling Mar 27, 2022
@codeclimate
Copy link

codeclimate bot commented Mar 27, 2022

Code Climate has analyzed commit 8399750 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit 02bf943 into scolladon:main Mar 27, 2022
@scolladon scolladon deleted the feature/markdown_spelling branch March 27, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants