Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wave meta file delta generation #293

Merged
merged 4 commits into from
Apr 21, 2022
Merged

Conversation

scolladon
Copy link
Owner

What does this pull request contain?


  • Added (for new features).
  • Changed (for changes in existing functionality).
  • Deprecated (for soon-to-be removed features).
  • Removed (for now removed features).
  • Fixed (for any bug fixes).
  • Security (for vulnerability fixes).

Explain your changes


Make sure the extension is taken into account when copying metafile

Does this close any currently open issues?


closes #286

  • Jest test added to check the fix is applied.

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #293 (d627202) into main (001c07e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #293   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          634       633    -1     
=========================================
- Hits           634       633    -1     
Impacted Files Coverage Δ
src/service/waveHandler.js 100.00% <ø> (ø)
src/service/standardHandler.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 001c07e...d627202. Read the comment docs.

mehdicherf
mehdicherf previously approved these changes Apr 21, 2022
@codeclimate
Copy link

codeclimate bot commented Apr 21, 2022

Code Climate has analyzed commit d627202 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit ceaff65 into main Apr 21, 2022
@scolladon scolladon deleted the fix/wave-type-delta-generation branch April 21, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Specific Wave metadata type Components are not added in Output directory
2 participants