feat: enable git diff on submodules

[hsaraujo]

Fixes isGit method to check whether .git is a folder or file (this is the case on submodules)

What does this pull request contain?

---

• Added (for new features).
• Changed (for changes in existing functionality).
• Deprecated (for soon-to-be removed features).
• Removed (for now removed features).
• Fixed (for any bug fixes).
• Security (for vulnerability fixes).

Explain your changes

---

It adds new condition on the isGit method that also checks whether a .git file exists

Where has this been tested?

---

Locally

Operating System: MacOS Monterey

yarn version: 1.22.19

node version: 18.8.0

git version: 2.37.0

sfdx version: 7.166.1

sgd plugin version: …

[codecov]

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (7e654b9) compared to base (a29baec).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #353   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          733       735    +2     
=========================================
+ Hits           733       735    +2     

Impacted Files	Coverage Δ
src/utils/cliHelper.js	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[scolladon]

Technically the new addition looks ok.
I think it could be improved with one or two unit test

// cliHelper.test.js
test('do not throw errors when repo contains git folder', async () => {
	...
})

test('do not throw errors when repo contains git file', async () => {
	...
})

[scolladon]

Hi @hsaraujo!

Thanks for this addition.
Could you educate us on which use case this PR is going to to enable?
I can think of one or two but I really would like your input here, maybe it would benefit from an explanation in the README.

[hsaraujo]

Hi @scolladon thanks for the quick feedback.. I will add some unit tests to it.
This PR enables users to run the plugin on git projects that contains submodules. In these cases, the submodules don't have a .git folder on their root, but they do have a .git file.

[hsaraujo]

Hi @scolladon I've added some unit tests to it.
I also had to fix the fs mock implementation as it couldn't check subfolders either

[scolladon]

LGTM

Only a few remarks(nit) tag, up to you @hsaraujo to take them or not 😉
Let me know if you want to take care of them or not so I know if I should wait a bit before merging

[codeclimate]

Code Climate has analyzed commit 7e654b9 and detected 0 issues on this pull request.

View more on Code Climate.

[scolladon]

LGTM

Thanks for this nice contribution