Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows path separator with git #436

Merged
merged 7 commits into from
Jan 30, 2023

Conversation

scolladon
Copy link
Owner

Explain your changes


Normalized path used with to git commands
Ensure path is formatted according to git expectation (unix style)

Does this close any currently open issues?


closes #434

  • Jest test added to check the fix is applied.

Any particular element that can be tested locally


Use windows architecture

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (42d996e) compared to base (037c394).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #436   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          806       810    +4     
=========================================
+ Hits           806       810    +4     
Impacted Files Coverage Δ
src/utils/fileGitDiff.js 100.00% <100.00%> (ø)
src/utils/fsHelper.js 100.00% <100.00%> (ø)
src/utils/repoGitDiff.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scolladon scolladon enabled auto-merge (squash) January 27, 2023 16:47
@scolladon scolladon force-pushed the fix/windows-path-separator-for-git branch from 54c32cf to 42d996e Compare January 30, 2023 13:06
@codeclimate
Copy link

codeclimate bot commented Jan 30, 2023

Code Climate has analyzed commit 42d996e and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit b760a7e into main Jan 30, 2023
@scolladon scolladon deleted the fix/windows-path-separator-for-git branch January 30, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v5.11.1] incremental file copy issue on windows (still working in v5.8.0)
2 participants