Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add FSC metadata #444

Merged
merged 3 commits into from
Feb 10, 2023
Merged

feat: add FSC metadata #444

merged 3 commits into from
Feb 10, 2023

Conversation

scolladon
Copy link
Owner

@scolladon scolladon commented Feb 10, 2023

Explain your changes


Add FSC Metadatas:

  • RecordActionDeployment
  • RecommendationStrategy
  • ActionPlanTemplate

Does this close any currently open issues?


closes #443

- [ ] Jest test added to check the fix is applied.

Any particular element that can be tested locally


You need FSC package

Any other comments


None

@codeclimate
Copy link

codeclimate bot commented Feb 10, 2023

Code Climate has analyzed commit cfbcf04 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (cfbcf04) compared to base (36565ad).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #444   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          817       817           
=========================================
  Hits           817       817           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scolladon scolladon changed the title feat: add RecordActionDeployment and RecommendationStrategy metadata feat: add FSC metadata Feb 10, 2023
@scolladon scolladon merged commit fcf9e02 into main Feb 10, 2023
@scolladon scolladon deleted the feat/fsc-metadatas branch February 10, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support to more metadata types
2 participants