fix: in file comparison while ignoring whitespace (#478 #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #478 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 31
Lines 817 819 +2
=========================================
+ Hits 817 819 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mehdicherf
previously approved these changes
Feb 24, 2023
scolladon
force-pushed
the
fix/infile-ignore-whitespace-issue
branch
from
90e579d
to
829e4ef
Compare
|
Code Climate has analyzed commit 829e4ef and detected 0 issues on this pull request. View more on Code Climate. |
scolladon
changed the title
scolladon
added a commit
that referenced
this pull request
Feb 26, 2023
* fix: remove `--word-diff-regex` for inFile git diff comparison * build: upgrade dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes
Remove
--word-diff-regex=|[^[:space:]]parameter when getting diff content of file (for custom labels or sharing rules or workflow rule for instance)This parameter is working fine with
--numstatand allow the plugin to get files that have been changed while ignoring whitespace changesBut it does not works when working with full diff content and was returning nothing is changed even when there are not blank characters changes
Does this close any currently open issues?