fix: fsHelper.pathExist when path does not exist
#482
Conversation
nikitakarpenkov
requested review from
scolladon and
mehdicherf
as code owners
|
Hi @nikitakarpenkov ! Thank you very much for this PR, really appreciated I'll check the issue locally soon and the fix as well. What would be great is to add a unit test in the related test class so we can make sure the failing use case is covered |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 31
Lines 817 817
=========================================
Hits 817 817
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
scolladon
changed the title
fsHelper.pathExist when path returns git null content (#481)
scolladon
force-pushed
the
fix/path-exists-issue
branch
from
0f3db94
to
c503246
Compare
|
Code Climate has analyzed commit 57f78ef and detected 0 issues on this pull request. View more on Code Climate. |
scolladon
changed the title
fsHelper.pathExist when path returns git null content (#481)fsHelper.pathExist when path does not exist (#481)
scolladon
changed the title
fsHelper.pathExist when path does not exist (#481)fsHelper.pathExist when path does not exist
* fix: correct check for path existence (#481) * refactor: remove null check * test: implement `pathExists` spec * test: fix domain tests * refactor: simplify implementation a bit * build: upgrade dependencies --------- Co-authored-by: Sébastien Colladon <[email protected]>
Explain your changes
Corrects a bug where an existing path in git was identified as non-existent.
Does this close any currently open issues?
closes #481
Any particular element that can be tested locally
Any other comments