Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flow translation post processing #487

Merged
merged 2 commits into from
Feb 26, 2023

Conversation

scolladon
Copy link
Owner

Explain your changes


Flow translation post processing was broken because it was not passing the right config variable to the scanExtension methods
This PR fix this issue and add more precise assertion to the related unit tests

@codeclimate
Copy link

codeclimate bot commented Feb 26, 2023

Code Climate has analyzed commit 78d1077 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (78d1077) compared to base (0855dcc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #487   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          816       816           
=========================================
  Hits           816       816           
Impacted Files Coverage Δ
src/post-processor/flowTranslationProcessor.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scolladon scolladon enabled auto-merge (squash) February 26, 2023 19:21
@scolladon scolladon merged commit 225c435 into main Feb 26, 2023
@scolladon scolladon deleted the fix/flow-translation-pocessor-scan branch February 26, 2023 19:21
@github-actions
Copy link

Shipped in release v5.13.3.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant