feat: implement diff detection using file content comparison #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 31
Lines 816 844 +28
=========================================
+ Hits 816 844 +28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
scolladon
force-pushed
the
feat/inFile-json-compare
branch
7 times, most recently
from
9227104
to
f82cdfa
Compare
mehdicherf
previously approved these changes
Mar 14, 2023
scolladon
force-pushed
the
feat/inFile-json-compare
branch
from
f82cdfa
to
67183f4
Compare
scolladon
force-pushed
the
feat/inFile-json-compare
branch
from
67183f4
to
5c54cce
Compare
|
Code Climate has analyzed commit 5c54cce and detected 0 issues on this pull request. View more on Code Climate. |
mehdicherf
approved these changes
Mar 14, 2023
|
Shipped in release $ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes
Migrate from our line by line in house algorithm to detect change in metadata located inside files (Workflow, SharingRule, Labels, etc).
To a more robust/understandable/standard object comparison algorithm
Performance it is equivalent as the previous implementation (surprisingly)
It is more memory consuming than the previous implementation, but I don't see an impact in CI/CD (let's see)
It does not care about the indentation of the file
I have refactored a bit the code so the responsibility are more segregated and easier to unit test
Integration test are more integrated
Does this close any currently open issues?
closes #480