Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for forecasting metadata types #518

Merged
merged 6 commits into from
Mar 14, 2023

Conversation

jdkgabri
Copy link
Contributor

@jdkgabri jdkgabri commented Mar 14, 2023

Explain your changes

Added forecasting related metadata types.

Does this close any currently open issues?


closes #

  • Jest test added to check the fix is applied.

Any particular element that can be tested locally


Any other comments

Tested on Windows 11 with API version 57.

Not incrementing API version/release. To be decided up to the mantainers.


@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (449948d) 100.00% compared to head (59b8160) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #518   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          816       816           
=========================================
  Hits           816       816           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdkgabri jdkgabri marked this pull request as ready for review March 14, 2023 16:11
Copy link
Owner

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, nice job so far

I have one comment, please address it so we can include this contribution

src/metadata/v57.json Show resolved Hide resolved
@scolladon scolladon self-assigned this Mar 14, 2023
@jdkgabri jdkgabri changed the title feat: update v57.json to support forecasting metadata types feat: add support for forecasting metadata types Mar 14, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 14, 2023

Code Climate has analyzed commit 59b8160 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks for this contribution

@scolladon scolladon merged commit 89d6aa7 into scolladon:main Mar 14, 2023
@github-actions
Copy link

Shipped in release v5.14.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants