Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend metadata content pruning to more eligible types #533

Merged
merged 56 commits into from
Apr 21, 2023

Conversation

scolladon
Copy link
Owner

@scolladon scolladon commented Mar 26, 2023

Explain your changes


Extends metadata content filtering to those types:

  • WorkFlow (and every sub types)
  • SharingRule (and every sub types)
  • AssignmentRule
  • AutoResponseRule
  • EscalationRule
  • MatchingRule
  • GlobalValueSetTranslation
  • StandardValueSetTranslation
  • Profile
  • Translation
  • CustomObjectTranslation

Does this close any currently open issues?


closes #198
closes #328
closes #525
closes #90

  • Jest test added to check the fix is applied.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 10738 lines exceeds the maximum allowed for the inline comments feature.

@scolladon scolladon changed the title Feat/more infile metadata handling feat: extend metadata content filtering to more eligible types Mar 26, 2023
@scolladon scolladon added the do not merge Do not merge this PR label Mar 26, 2023
@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (bb8dfb0) 100.00% compared to head (5fd7f50) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #533   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        32    +1     
  Lines          862       898   +36     
=========================================
+ Hits           862       898   +36     
Impacted Files Coverage Δ
src/service/customObjectHandler.js 100.00% <ø> (ø)
src/service/inBundleHandler.js 100.00% <ø> (ø)
src/metadata/metadataManager.js 100.00% <100.00%> (ø)
src/post-processor/flowTranslationProcessor.js 100.00% <100.00%> (ø)
src/post-processor/packageGenerator.js 100.00% <100.00%> (ø)
src/service/ObjectTranslationHandler.js 100.00% <100.00%> (ø)
src/service/inFileHandler.js 100.00% <100.00%> (ø)
src/service/inResourceHandler.js 100.00% <100.00%> (ø)
src/service/lwcHandler.js 100.00% <100.00%> (ø)
src/service/standardHandler.js 100.00% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 10298 lines exceeds the maximum allowed for the inline comments feature.

@scolladon scolladon force-pushed the feat/more-infile-metadata-handling branch from ad76e85 to d2f48cb Compare April 17, 2023 15:57
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 10299 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 11331 lines exceeds the maximum allowed for the inline comments feature.

@scolladon scolladon force-pushed the feat/more-infile-metadata-handling branch from a09ae18 to bb6e4d8 Compare April 20, 2023 09:52
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 11331 lines exceeds the maximum allowed for the inline comments feature.

mehdicherf
mehdicherf previously approved these changes Apr 20, 2023
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 11489 lines exceeds the maximum allowed for the inline comments feature.

@scolladon scolladon force-pushed the feat/more-infile-metadata-handling branch from 442f1a0 to 5fd7f50 Compare April 20, 2023 14:43
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 11499 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Apr 20, 2023

Code Climate has analyzed commit 5fd7f50 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon changed the title feat: extend metadata content filtering to more eligible types feat: extend metadata content pruning to more eligible types Apr 21, 2023
@scolladon scolladon merged commit 2576cf7 into main Apr 21, 2023
@scolladon scolladon deleted the feat/more-infile-metadata-handling branch April 21, 2023 06:42
@github-actions
Copy link

Shipped in release v5.18.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants