Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy empty file from git #547

Merged
merged 11 commits into from
Mar 31, 2023
Merged

fix: copy empty file from git #547

merged 11 commits into from
Mar 31, 2023

Conversation

scolladon
Copy link
Owner

Explain your changes


Update readPathFromGit and copyFiles so it can treat empty content like real content of a file

Does this close any currently open issues?


closes #546

  • Jest test added to check the fix is applied.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (afc0d9f) 100.00% compared to head (4a55e3f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #547   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          843       848    +5     
=========================================
+ Hits           843       848    +5     
Impacted Files Coverage Δ
src/utils/childProcessUtils.js 100.00% <100.00%> (ø)
src/utils/cliHelper.js 100.00% <100.00%> (ø)
src/utils/fsHelper.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mehdicherf
mehdicherf previously approved these changes Mar 31, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 31, 2023

Code Climate has analyzed commit 4a55e3f and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon changed the title fix: file copy from git when file content is empty fix: copy empty file from git Mar 31, 2023
@scolladon scolladon merged commit 577f750 into main Mar 31, 2023
@scolladon scolladon deleted the fix/infolder-metadata-handler branch March 31, 2023 10:03
@github-actions
Copy link

Shipped in release v5.16.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to handle email templates
2 participants