Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fast flowTranslationProcessor exit #553

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

scolladon
Copy link
Owner

Explain your changes


Implement fast exit of flowTranslationProcessor when the changes detected does not have Flows as there is no point to look for translation then

Does this close any currently open issues?


closes #

  • Jest test added to check the fix is applied.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 10496 lines exceeds the maximum allowed for the inline comments feature.

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (39bc69e) 100.00% compared to head (4233d78) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #553   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          848       850    +2     
=========================================
+ Hits           848       850    +2     
Impacted Files Coverage Δ
src/post-processor/flowTranslationProcessor.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scolladon scolladon force-pushed the feat/flow-translation-fast-exit branch from 2113192 to 4233d78 Compare April 1, 2023 08:03
@codeclimate
Copy link

codeclimate bot commented Apr 1, 2023

Code Climate has analyzed commit 4233d78 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon changed the title refactor: fast flowTranslationProcessor exit feat: fast flowTranslationProcessor exit Apr 1, 2023
@scolladon scolladon merged commit 2e8f9fb into main Apr 3, 2023
@scolladon scolladon deleted the feat/flow-translation-fast-exit branch April 3, 2023 09:44
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Shipped in release v5.17.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants