Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: process lines related to metadata entity only #554

Merged
merged 4 commits into from
Apr 4, 2023

Conversation

scolladon
Copy link
Owner

Explain your changes


Check if a line is processeable as a metadata candidat before processing it.
Check is implemented at the base class level (StandardHandler.js) and declined when needed for specific use cases (InFolder metadata, InResource metadata and WaveMetadata specificities)

Local functional test, e2e test and perf test are passing

Does this close any currently open issues?


closes #548

  • Jest test added to check the fix is applied.

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2e8f9fb) 100.00% compared to head (8cd9f05) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #554   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          850       863   +13     
=========================================
+ Hits           850       863   +13     
Impacted Files Coverage Δ
src/service/inFolderHandler.js 100.00% <100.00%> (ø)
src/service/inResourceHandler.js 100.00% <100.00%> (ø)
src/service/standardHandler.js 100.00% <100.00%> (ø)
src/service/waveHandler.js 100.00% <100.00%> (ø)
src/utils/fsHelper.js 100.00% <100.00%> (ø)
src/utils/gitConstants.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scolladon scolladon force-pushed the fix/strip-non-metadata-file branch from 4115fbb to 8cd9f05 Compare April 3, 2023 09:48
@codeclimate
Copy link

codeclimate bot commented Apr 3, 2023

Code Climate has analyzed commit 8cd9f05 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit f4c5483 into main Apr 4, 2023
@scolladon scolladon deleted the fix/strip-non-metadata-file branch April 4, 2023 08:17
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Shipped in release v5.17.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore .eslintrc.json at project init
2 participants