Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SlackApp and ViewDefinition metadata type #624

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

scolladon
Copy link
Owner

Explain your changes


Add SlackApp metadata type support
Add ViewDefinition metadata type support

Does this close any currently open issues?


closes #621

Any particular element that can be tested locally


Any other comments


@scolladon
Copy link
Owner Author

Could help us and early test this PR please @legetz ?
You can follow those steps to test it locally:
https://github.com/scolladon/sfdx-git-delta/blob/main/CONTRIBUTING.md#testing-the-plugin-from-a-pull-request

Let us know if it fits what you need

mehdicherf
mehdicherf previously approved these changes Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9c5c8ee) 100.00% compared to head (3319b3e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #624   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          889       889           
=========================================
  Hits           889       889           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mehdicherf
mehdicherf previously approved these changes Jun 1, 2023
mehdicherf
mehdicherf previously approved these changes Jun 2, 2023
@scolladon scolladon force-pushed the feat/add-slack-metadata branch 3 times, most recently from c957e5a to 4cb384f Compare June 2, 2023 10:05
@scolladon scolladon force-pushed the feat/add-slack-metadata branch 8 times, most recently from 497e8ad to 5b91de9 Compare June 2, 2023 15:01
@codeclimate
Copy link

codeclimate bot commented Jun 2, 2023

Code Climate has analyzed commit 3319b3e and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit 2dd9ce8 into main Jun 2, 2023
@scolladon scolladon deleted the feat/add-slack-metadata branch June 2, 2023 16:30
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Shipped in release v5.21.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Apex SDK for Slack
2 participants