Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metadata to ignore by default when deleted #631

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

scolladon
Copy link
Owner

Explain your changes


Add default metadata to ignore when deleted

Does this close any currently open issues?


closes #620

  • Jest tests added to cover the fix.
  • NUT tests added to cover the fix.
  • E2E tests added to cover the fix.

@scolladon scolladon force-pushed the feat/record-types-not-deletable branch from eb55060 to 4663094 Compare June 5, 2023 14:00
@codeclimate
Copy link

codeclimate bot commented Jun 5, 2023

Code Climate has analyzed commit 4663094 and detected 0 issues on this pull request.

View more on Code Climate.

mehdicherf
mehdicherf previously approved these changes Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2dd9ce8) 100.00% compared to head (44357e3) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #631   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          889       891    +2     
=========================================
+ Hits           889       891    +2     
Impacted Files Coverage Δ
src/post-processor/flowTranslationProcessor.js 100.00% <100.00%> (ø)
src/utils/ignoreHelper.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scolladon scolladon merged commit 5ff3379 into main Jun 5, 2023
@scolladon scolladon deleted the feat/record-types-not-deletable branch June 5, 2023 15:38
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Shipped in release v5.21.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Record Types from destructive changes manifests
2 participants