Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add API v58 support #635

Merged
merged 4 commits into from
Jun 9, 2023
Merged

feat: add API v58 support #635

merged 4 commits into from
Jun 9, 2023

Conversation

scolladon
Copy link
Owner

Explain your changes


add API v58 metadata definition

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (90b2ce2) 100.00% compared to head (c4992ea) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #635   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          891       891           
=========================================
  Hits           891       891           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeclimate
Copy link

codeclimate bot commented Jun 9, 2023

Code Climate has analyzed commit c4992ea and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit c811567 into main Jun 9, 2023
@scolladon scolladon deleted the feat/v58 branch June 9, 2023 13:06
@github-actions
Copy link

Shipped in release v5.22.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

@jonny-harte
Copy link

hi @scolladon when will this be the stable version?

@scolladon
Copy link
Owner Author

Hi @jonny-harte, we'll move the latest and stable version to the latest version containing the v58 api today or tomorrow

@Raspikabek
Copy link

Hey @scolladon , where are these json file definitions for metadata types coming from? I mean, is there any Salesforce documentation about this list of files?

For context: I'm building a plugin myself and I need something similar to identify the metadata type name, directory file and if contains child elements like CustomObjects that contains CustomField.

(apologies this might not be the right place, but didn't see fair to raise an 'issue' for this.)

@scolladon
Copy link
Owner Author

Hi @Raspikabek !

Those json files have been generated long time ago from the metadata wsdl if I remember correctly. We converted it from xml to json and then rework the format a bit so it is easier to consume.

But today there is another way to do it, much more easier. We have plan to refactor the plugin to use it.
It is the Metadata Registry, if you need to have metadata definition in your plugin I think you should consider using this library.

I'll be happy to discuss design with you for your new plugin ! Contact me on linkedin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants