Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty inFile metadata detection #683

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Conversation

scolladon
Copy link
Owner

Explain your changes


Fix empty check
Improve spec

Does this close any currently open issues?


closes #

  • Jest tests added to cover the fix.
  • NUT tests added to cover the fix.
  • E2E tests added to cover the fix.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ca6d5a7) 100.00% compared to head (b24d889) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #683   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines          952       952           
=========================================
  Hits           952       952           
Files Changed Coverage Δ
src/utils/metadataDiff.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeclimate
Copy link

codeclimate bot commented Aug 30, 2023

Code Climate has analyzed commit b24d889 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit 66ef9d9 into main Aug 30, 2023
19 checks passed
@scolladon scolladon deleted the fix/empty-scoped-metadata-check branch August 30, 2023 15:45
@github-actions
Copy link

Shipped in release v5.25.2.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant