fix: use default export for main module #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scolladon
force-pushed
the
fix/default-import-issue
branch
from
ad25739
to
53a32f0
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 33 33
Lines 957 957
Branches 96 96
=========================================
Hits 957 957 ☔ View full report in Codecov by Sentry. |
|
Code Climate has analyzed commit 8976696 and detected 0 issues on this pull request. View more on Code Climate. |
|
The megalinter lint issue seems to be an issue with trivy The npm-lint issue is something I could not fix with intermediate version or lock file fixing. We need to wait the next release of Mutation testing is also broken, I'll treat it in another PR |
mehdicherf
approved these changes
Oct 4, 2023
|
Shipped in release $ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]Happy incremental deployment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes
Use default export instead of named export.
This commit introduced a breaking change in the way the main module is exported.
It used a named export instead of a default export.
This change was introduce inside a minor version with a breaking change which is not compliant with the semantic versioning rules.
The change aim to fix that
Does this close any currently open issues?
closes #701