Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript default exported value #706

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

scolladon
Copy link
Owner

@scolladon scolladon commented Oct 6, 2023

Explain your changes


Fix how the default is exported in typescript
Make sure the compilation produce code that can be called those ways:

const sgd = require('sgd')
import sgd from 'sgd'

require contract is tested in a dedicated functional test
import contract is tested in the nut tests and e2e tests

Does this close any currently open issues?


closes #701

  • Jest tests added to cover the fix.
  • NUT tests added to cover the fix.
  • E2E tests added to cover the fix.

@scolladon
Copy link
Owner Author

Could you help us with test @pawel-id please ?

Here are to step to install a PR locally

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (44d7e6a) 100.00% compared to head (68387f8) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #706   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        34    +1     
  Lines          957       974   +17     
  Branches        96        96           
=========================================
+ Hits           957       974   +17     
Files Coverage Δ
src/main.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scolladon scolladon enabled auto-merge (squash) October 6, 2023 17:40
@scolladon scolladon force-pushed the fix/default-import-issue-for-real branch from 3b6e999 to 68387f8 Compare October 6, 2023 17:42
@codeclimate
Copy link

codeclimate bot commented Oct 6, 2023

Code Climate has analyzed commit 68387f8 and detected 0 issues on this pull request.

View more on Code Climate.

@pawel-id
Copy link
Contributor

pawel-id commented Oct 6, 2023

Hi @scolladon,

I did check this version as module referenced in our deployment tool and this time everything is fine. The behavior is exactly as expected: sfdx-git-delta exports single function sgd.

I also installed plugin locally and did few checks on our repository. They were fine too.

It looks good to me.

@scolladon
Copy link
Owner Author

Thank you very much for your contribution!
It was a bumpy road 😅, I learned a lot, thank you for that too

@scolladon scolladon merged commit 1a4c518 into main Oct 9, 2023
22 of 24 checks passed
@scolladon scolladon deleted the fix/default-import-issue-for-real branch October 9, 2023 07:58
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Shipped in release v5.26.2.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Happy incremental deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changed export from default to named
3 participants