-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typescript default exported value #706
Conversation
Could you help us with test @pawel-id please ? Here are to step to install a PR locally |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #706 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 33 34 +1
Lines 957 974 +17
Branches 96 96
=========================================
+ Hits 957 974 +17
☔ View full report in Codecov by Sentry. |
3b6e999
to
68387f8
Compare
Code Climate has analyzed commit 68387f8 and detected 0 issues on this pull request. View more on Code Climate. |
Hi @scolladon, I did check this version as module referenced in our deployment tool and this time everything is fine. The behavior is exactly as expected: sfdx-git-delta exports single function sgd. I also installed plugin locally and did few checks on our repository. They were fine too. It looks good to me. |
Thank you very much for your contribution! |
Shipped in release $ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected] Happy incremental deployment! |
Explain your changes
Fix how the default is exported in typescript
Make sure the compilation produce code that can be called those ways:
require
contract is tested in a dedicatedfunctional
testimport
contract is tested in thenut
tests ande2e
testsDoes this close any currently open issues?
closes #701