fix: boolean attribute and comment xml parsing #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 35 35
Lines 988 991 +3
Branches 97 98 +1
=========================================
+ Hits 988 991 +3 ☔ View full report in Codecov by Sentry. |
1 task
mehdicherf
previously approved these changes
Dec 12, 2023
scolladon
force-pushed
the
fix/boolean-attribute-and-comment-xml-parsing
branch
from
123f6af
to
716fed3
Compare
scolladon
force-pushed
the
fix/boolean-attribute-and-comment-xml-parsing
branch
2 times, most recently
from
d08cb49
to
260cda3
Compare
scolladon
force-pushed
the
fix/boolean-attribute-and-comment-xml-parsing
branch
from
260cda3
to
b8014ba
Compare
|
Code Climate has analyzed commit b8014ba and detected 0 issues on this pull request. View more on Code Climate. |
scolladon
added a commit
that referenced
this pull request
Dec 12, 2023
Co-authored-by: joernflath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes
Improve
fast-xml-parserxml builder configurationDoes this close any currently open issues?
closes #737
Any particular element that can be tested locally
Any other comments