Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the WebStoreTemplate metadata type #776

Closed
scolladon opened this issue Jan 30, 2024 Discussed in #774 · 12 comments · Fixed by #775
Closed

Support the WebStoreTemplate metadata type #776

scolladon opened this issue Jan 30, 2024 Discussed in #774 · 12 comments · Fixed by #775

Comments

@scolladon
Copy link
Owner

Discussed in #774

Originally posted by marcoalmodova January 30, 2024
Hi, I was checking the files with the API versions and I could not find it there, but can the WebStoreTemplate metadata type be supported?
We are using the plugin in a project and it does not detect the changes to this type of metadata.

There is the SF doc about it: https://developer.salesforce.com/docs/atlas.en-us.api_meta.meta/api_meta/meta_webstoretemplate.htm

Thanks!

@marcoalmodova
Copy link

Thanks for the quick response and action, @scolladon ! ❤️

Copy link

Shipped in release v5.36.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Happy incremental deployment!

@marcoalmodova
Copy link

Thanks again, @scolladon ! Buying you a beer ;)

@scolladon
Copy link
Owner Author

Thank you very much @marcoalmodova !
You are the first one, it really means something to me 🥹

@marcoalmodova
Copy link

marcoalmodova commented Jan 31, 2024

Hey @scolladon , I updated the plugin and tested it, but it's not picking up the changes. I tested with a commit right before and the one adding a webStoreTemplate file. Can you have a second look at it, please?

@scolladon
Copy link
Owner Author

Hi @marcoalmodova, the plugin is updated but only the channel latest-rc has the new change.

Could you check the version you have ? (sfdx plugins)

@marcoalmodova
Copy link

Hi @scolladon , yes, I have the latest version: sfdx-git-delta 5.36.0 (latest-rc)

@marcoalmodova
Copy link

marcoalmodova commented Jan 31, 2024

Maybe because the folder name is camel cased? Not sure if that will make a difference in the way the plugin parses the files. In the PR I can see that the folder name is not camel cased.

image

@scolladon
Copy link
Owner Author

That's it @marcoalmodova, the documentation says the file extension and the folder name is lower case.
The plugin cannot match on either as in your exemple it is camel case and the plugin is case sensitive.
If you could make both the folder and the file extension lower case it would match.
Also the folder is webstoretemplate without an "s" in the end according to the doc.

@marcoalmodova
Copy link

But that's how the file is pulled from the scratch orgs, I didn't rename anything (the same about the folder).
So maybe the SF docs are wrong, but in any case the plugin should expect it to be camel cased.
What do you think?

@scolladon
Copy link
Owner Author

We already had this kind of situation in the past. We prefer to use the documentation as the source of truth.

Just to be sure, you could create an issue in sf cli and see how they propose to fix it (the doc or the way the cli retrieve). You could link this issue to the one in the cli.

In the meantime, you can change the folder name to be lower case, next retrieve will not change the folder.

@marcoalmodova
Copy link

Renaming worked just fine, thanks.
I will also open an issue on the sf cli repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants