Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metadata type detection on file extension #835

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

scolladon
Copy link
Owner

Explain your changes


Add sites type (Site, SiteDotCom and ExperienceBundle) to the suffix exception list
As those types have the same extension they should not be detected using suffix but they should be detected using folder

Does this close any currently open issues?


closes #834

  • Jest tests added to cover the fix.
  • NUT tests added to cover the fix.
  • E2E tests added to cover the fix.

Any particular element that can be tested locally


Have multiple site, siteDotCom and experienceBundle metadata

Copy link

codeclimate bot commented Apr 17, 2024

Code Climate has analyzed commit e8b1c7b and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit 181d8c6 into main Apr 17, 2024
5 of 19 checks passed
@scolladon scolladon deleted the fix/site-type-detection branch April 17, 2024 15:22
Copy link

Shipped in release v5.38.4.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Happy incremental deployment!

a-ursu added a commit to deloitte-engineering/sfdx-git-delta that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

force-app folder appears in the ExperienceBundle type in package.xml
1 participant