Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sub directory detection when walking vcs content #880

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

scolladon
Copy link
Owner

@scolladon scolladon commented Jun 6, 2024

Explain your changes


Use the existing subDir algorithm instead of the local sibling folder detection

Does this close any currently open issues?


closes #878

  • Jest tests added to cover the fix.

Any particular element that can be tested locally


use --source parameter with '.' value

Copy link

codeclimate bot commented Jun 6, 2024

Code Climate has analyzed commit 99c20f3 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (eb5a47b) to head (99c20f3).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #880   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         1067      1067           
  Branches       114       114           
=========================================
  Hits          1067      1067           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scolladon
Copy link
Owner Author

Could you help here by testing this version please @jdkgabri ?
You can follow those steps to test locally the current version

@jdkgabri
Copy link
Contributor

jdkgabri commented Jun 8, 2024

Could you help here by testing this version please @jdkgabri ? You can follow those steps to test locally the current version

I can confirm this branch works properly! thanks for the fix!

@scolladon scolladon merged commit 788478d into main Jun 8, 2024
18 of 22 checks passed
@scolladon scolladon deleted the fix/empty-source-parameter branch June 8, 2024 18:43
Copy link

github-actions bot commented Jun 8, 2024

Shipped in release v5.40.1.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Happy incremental deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package.xml is generated empty
2 participants