Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error after update #67

Closed
muzichen opened this issue Jun 13, 2024 · 4 comments
Closed

Error after update #67

muzichen opened this issue Jun 13, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@muzichen
Copy link

Description

Today I just update the cyberdream colorscheme, and it tells me it has break changes. When I restart nvim there is an error message like this:
image

image

And I use lazy.vim.

Neovim version?

0.10.0

What should happen?

No Error message.

What happened instead?

Error message is showed.

Your configuration

return {
  "scottmckendry/cyberdream.nvim",
  {
    "LazyVim/LazyVim",
    opts = {
      colorscheme = "cyberdream",
    },
  }
}
@muzichen muzichen added the bug Something isn't working label Jun 13, 2024
@catoa
Copy link

catoa commented Jun 13, 2024

I ran into this as well with my lazyvim config and was able to resolve it by updating my lualine config. I now have

return {
  ...
  {
    "nvim-lualine/lualine.nvim",
    opts = function()
      local cyberdream = require("lualine.themes.cyberdream").get_theme()
      return {
        options = {
          ...
          theme = cyberdream
        }
      }
  }
}

I've redacted some things but I think this is the minimum to get this working for now.

@scottmckendry
Copy link
Owner

@muzichen thanks for raising the issue. @catoa is right. Take a look at the pinned issue #65 that has some more info on this.

This was the breaking change introduced in v2.

@scottmckendry scottmckendry added the waiting for op This issue is waiting for a response from the original poster label Jun 13, 2024
@scottmckendry
Copy link
Owner

Ignore my last comment and the v2 release entirely. A big mess up on my part will have broken any lualine configs using the "auto" theme.

I've resolved this now with the v3 release. If your config working in v1 it should now work again.

@scottmckendry scottmckendry added waiting for op This issue is waiting for a response from the original poster and removed waiting for op This issue is waiting for a response from the original poster labels Jun 13, 2024
@muzichen
Copy link
Author

@scottmckendry Thanks for your great work and thanks @catoa , it works.

@scottmckendry scottmckendry removed the waiting for op This issue is waiting for a response from the original poster label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants