Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(colors, highlights): improved NonText readability #74

Merged
merged 7 commits into from
Jun 15, 2024
Merged

feat(colors, highlights): improved NonText readability #74

merged 7 commits into from
Jun 15, 2024

Conversation

AlejandroSuero
Copy link
Contributor

@scottmckendry a little tweak on the colours and the highlights to improve readability when using NonText and NonText+CursorLine. Usually used by AI plugins and terminal based plugins to show "ghost text".

Warning

Toggling light and dark 💥

  • Before:
Screen.Recording.2024-06-15.at.00.26.19.mov

Using :term:

Screen.Recording.2024-06-15.at.00.11.38.mov
  • After:
Screen.Recording.2024-06-15.at.00.25.24.mov

Using :term:

Screenshot 2024-06-15 at 00 16 14

@AlejandroSuero
Copy link
Contributor Author

I force pushed cause I don't know how (87aee45) got in the PR while I was writing it 🤔

@scottmckendry
Copy link
Owner

Wow @AlejandroSuero ! Appreciate all the work you're putting in on these PRs!

I think this is a very necessary change and should be fixed. However, I think we should try and make it work without affecting the base palette. As you can probably already tell, this has the knock-on effect of updating all of the extras that reference it.

You can use the util.blend function to produce new colors from the ones already available if there is nothing suitable in the palette itself.

@AlejandroSuero
Copy link
Contributor Author

@scottmckendry okay, I will play around to get a feel to mix the base palette.

lua/cyberdream/colors.lua Outdated Show resolved Hide resolved
Copy link
Owner

@scottmckendry scottmckendry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still showing lots of changes to extras, I think there still may be changes in colors.lua that differ from main. Can you check, please? Thanks!

@AlejandroSuero
Copy link
Contributor Author

@scottmckendry This has nothing to do with this PR but while I was playing around with the values, I used Telescope a lot and notice that there is no contrast between search and results and preview.

Here is my proposal.

  • Without changing anything but TelescopePrompt{Border,Normal,Prefix}):
Changed with red theme
  • Changing the colours:
Changed with a blueish theme

@AlejandroSuero
Copy link
Contributor Author

It's still showing lots of changes to extras, I think there still may be changes in colors.lua that differ from main. Can you check, please? Thanks!

Okay I am going to copy the main branch colors.

@AlejandroSuero
Copy link
Contributor Author

@scottmckendry now it only changes 1 files, I check the colour contrast and still works correctly both in light and dark

@scottmckendry scottmckendry merged commit aec0467 into scottmckendry:main Jun 15, 2024
@AlejandroSuero AlejandroSuero deleted the feature/improved-nontext-readability branch June 15, 2024 00:38
@scottmckendry
Copy link
Owner

@scottmckendry This has nothing to do with this PR but while I was playing around with the values, I used Telescope a lot and notice that there is no contrast between search and results and preview.

Here is my proposal.

  • Without changing anything but TelescopePrompt{Border,Normal,Prefix}):
Changed with red theme * Changing the colours: Changed with a blueish theme

@AlejandroSuero the blue looks quite nice. Do you have this change in a branch? Would like to see how it looks in person :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants